antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 7 Projects Releases 5 Activity Actions

If no evaluator is available in getEvaluator() and a new one can't be allocated, try waiting a few seconds several times before throwing a max thread count exception.

Browse source
This commit is contained in:
hns 2002-09-27 07:11:23 +00:00
parent 7cea5ece31
commit c591ab2e7d
1 changed files with 23 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/helma/framework/core/Application.java
View file

@ -253,6 +253,7 @@ public final class Application implements IPathElement, Runnable {
} catch (Exception ignore) {}
for (int i=0; i<minThreads; i++) {
RequestEvaluator ev = new RequestEvaluator (this);
ev.initScriptingEngine ();
freeThreads.push (ev);
allThreads.addElement (ev);
}
@ -350,16 +351,18 @@ public final class Application implements IPathElement, Runnable {
protected RequestEvaluator getEvaluator () {
if (stopped)
throw new ApplicationStoppedException ();
// first try
try {
return (RequestEvaluator) freeThreads.pop ();
} catch (EmptyStackException nothreads) {
int maxThreads = 12;
try {
maxThreads = Integer.parseInt (props.getProperty ("maxThreads"));
} catch (Exception ignore) {
// property not set, use default value
}
synchronized (this) {
int maxThreads = 12;
try {
maxThreads = Integer.parseInt (props.getProperty ("maxThreads"));
} catch (Exception ignore) {
// property not set, use default value
}
// allocate a new evaluator
if (allThreads.size() < maxThreads) {
logEvent ("Starting evaluator "+(allThreads.size()+1) +" for application "+name);
RequestEvaluator ev = new RequestEvaluator (this);
@ -367,8 +370,21 @@ public final class Application implements IPathElement, Runnable {
return (ev);
}
}
throw new RuntimeException ("Maximum Thread count reached.");
}
// we can't create a new evaluator, so we wait if one becomes available.
// give it 3 more tries, waiting 3 seconds each time.
for (int i=0; i<4; i++) {
try {
Thread.currentThread().sleep(3000);
return (RequestEvaluator) freeThreads.pop ();
} catch (EmptyStackException nothreads) {
// do nothing
} catch (InterruptedException inter) {
throw new RuntimeException ("Thread interrupted.");
}
}
// no luck, give up.
throw new RuntimeException ("Maximum Thread count reached.");
}
/**