antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 5 Projects Releases 5 Activity Actions

Explicitly use StringBuffer.append(String) instead of

Browse source 
StringBuffer.append(StringBuffer) in order to run on JDK 1.3 VMs which don't
have the latter, even when the code was compiled with JDK 1.4 +.
This commit is contained in:
hns 2004-06-25 13:30:27 +00:00
parent b3ee1d4060
commit c36745a7f5
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/helma/objectmodel/db/NodeManager.java
View file

@ -949,7 +949,7 @@ public final class NodeManager {
// tx.timer.beginEvent ("getNodes "+home); // tx.timer.beginEvent ("getNodes "+home);
if ((rel == null) || (rel.otherType == null) || !rel.otherType.isRelational()) { if ((rel == null) || (rel.otherType == null) || !rel.otherType.isRelational()) {
// this should never be called for embedded nodes // this should never be called for embedded nodes
throw new RuntimeException("NodeMgr.countNodes called for non-relational node " + throw new RuntimeException("NodeMgr.getNodes called for non-relational node " +
home); home);
} else { } else {
List retval = new ArrayList(); List retval = new ArrayList();
@ -1218,7 +1218,10 @@ public final class NodeManager {
tables.append(',').append(rel.additionalTables); tables.append(',').append(rel.additionalTables);
} }
StringBuffer b = new StringBuffer("SELECT count(*) FROM ").append(tables); // NOTE: we explicitly convert tables StringBuffer to a String
// before appending to be compatible with JDK 1.3
StringBuffer b = new StringBuffer("SELECT count(*) FROM ")
.append(tables.toString());
if (home.getSubnodeRelation() != null) { if (home.getSubnodeRelation() != null) {
// use the manually set subnoderelation of the home node // use the manually set subnoderelation of the home node
@ -1288,9 +1291,11 @@ public final class NodeManager {
} }
try { try {
// NOTE: we explicitly convert tables StringBuffer to a String
// before appending to be compatible with JDK 1.3
StringBuffer q = new StringBuffer("SELECT ").append(namefield) StringBuffer q = new StringBuffer("SELECT ").append(namefield)
.append(" FROM ") .append(" FROM ")
.append(tables); .append(tables.toString());
if (home.getSubnodeRelation() != null) { if (home.getSubnodeRelation() != null) {
q.append(" ").append(home.getSubnodeRelation()); q.append(" ").append(home.getSubnodeRelation());