Moved auto-ETag generation out of String encoding block so that ETags are

generated for binary responses. Some minor fixes in auto-ETag gen.
This commit is contained in:
hns 2002-11-21 15:46:58 +00:00
parent 8de915b1bb
commit c1c7f6af38

View file

@ -349,24 +349,26 @@ public final class ResponseTrans implements Externalizable {
encodingError = true;
response = buffer.toString ().getBytes ();
}
// if etag is not set, calc MD5 digest and check it
if (etag == null && lastModified == -1 &&
redir == null && error == null) try {
digest = MessageDigest.getInstance("MD5");
byte[] b = digest.digest(response);
etag = "\""+new String (Base64.encode(b))+"\"";
if (reqtrans != null && reqtrans.hasETag (etag)) {
response = new byte[0];
notModified = true;
}
} catch (Exception ignore) {
// Etag creation failed for some reason. Ignore.
}
buffer = null; // make sure this is done only once, even with more requsts attached
} else {
response = new byte[0];
}
}
// if etag is not set, calc MD5 digest and check it
if (etag == null && lastModified == -1 &&
redir == null && cache && error == null) try {
digest = MessageDigest.getInstance("MD5");
// if (contentType != null)
// digest.update (contentType.getBytes());
byte[] b = digest.digest(response);
etag = "\""+new String (Base64.encode(b))+"\"";
if (reqtrans != null && reqtrans.hasETag (etag)) {
response = new byte[0];
notModified = true;
}
} catch (Exception ignore) {
// Etag creation failed for some reason. Ignore.
}
notifyAll ();
// if there was a problem with the encoding, let the app know
if (encodingError)