antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 5 Projects Releases 5 Activity Actions

* Make Property.compareTo() immune against float/integer confusion, which is quite common in rhino.

Browse source
This commit is contained in:
hns 2006-12-01 13:21:23 +00:00
parent aaa15f5670
commit bfdd643a99
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/helma/objectmodel/db/Property.java
View file

@ -513,6 +513,9 @@ public final class Property implements IProperty, Serializable, Cloneable, Compa
return -1; return -1;
} }
if (type != ptype) { if (type != ptype) {
// float/integer sometimes get mixed up in Rhino
if ((type == FLOAT && ptype == INTEGER) || (type == INTEGER && ptype == FLOAT))
return Double.compare(((Number) value).doubleValue(), ((Number) pvalue).doubleValue());
throw new ClassCastException("uncomparable values " + this + "(" + type + ") : " + p + "(" + ptype + ")"); throw new ClassCastException("uncomparable values " + this + "(" + type + ") : " + p + "(" + ptype + ")");
} }