antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 5 Projects Releases 5 Activity Actions

Clean up Java-Object JS-constructor mess: get the right

Browse source 
constructor and invoke it instead of trying them all.
This commit is contained in:
hns 2003-11-10 16:30:24 +00:00
parent 49b08cc5a7
commit ae56944420
1 changed files with 8 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/helma/scripting/rhino/HopObject.java
View file

@ -84,23 +84,15 @@ public class HopObject extends ScriptableObject implements Wrapper {
String classname = c.app.getJavaClassForPrototype(prototype);
try {
Class clazz = Class.forName(classname);
Constructor[] cnst = clazz.getConstructors();
// brute force loop through constructors -
// alas, this isn't very pretty.
for (int i=0; i<cnst.length; i++) try {
FunctionObject fo = new FunctionObject("ctor", cnst[i], engine.global);
Object obj = fo.call(cx, engine.global, null, args);
return Context.toObject(obj, engine.global);
} catch (JavaScriptException x) {
Object value = x.getValue();
if (value instanceof Throwable) {
((Throwable) value).printStackTrace();
}
throw new EvaluatorException("Error in Java constructor: "+value);
} catch (Exception ignore) {
// constructor arguments didn't match
// try to get the constructor matching our arguments
Class[] argsTypes = new Class[args.length];
for (int i=0; i<argsTypes.length; i++) {
argsTypes[i] = args[i] == null ? null : args[i].getClass();
}
throw new ScriptingException("No matching Java Constructor found in "+clazz);
Constructor cnst = clazz.getConstructor(argsTypes);
// crate a new instance using the constructor
Object obj = cnst.newInstance(args);
return Context.toObject(obj, engine.global);
} catch (Exception x) {
System.err.println("Error in Java constructor: "+x);
throw new EvaluatorException(x.toString());