antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 5 Projects Releases 5 Activity Actions

Make public static methods unsynchronized but synchronize private instance methods.

Browse source 
This will allow some concurrent duplicate work being done, but it will remove the
bottleneck on the static methods. See bug 186:
http://helma.org/bugs/show_bug.cgi?id=186
This commit is contained in:
hns 2003-01-29 16:00:48 +00:00
parent 564dc9f585
commit a2c4745d8e
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/FESI/Interpreter/ClassInfo.java
View file

@ -94,7 +94,7 @@ public class ClassInfo {
* @param cls The class for which we look for the property. * @param cls The class for which we look for the property.
* @return The PropertyDescriptor or null if not found or in case of error * @return The PropertyDescriptor or null if not found or in case of error
*/ */
synchronized public static PropertyDescriptor lookupBeanField(String fieldName, Class cls) { public static PropertyDescriptor lookupBeanField(String fieldName, Class cls) {
ClassInfo classInfo = ClassInfo.ensureClassInfo(cls); ClassInfo classInfo = ClassInfo.ensureClassInfo(cls);
return classInfo.cachedBeanFieldLookup(fieldName, cls); return classInfo.cachedBeanFieldLookup(fieldName, cls);
} }
@ -109,7 +109,7 @@ public class ClassInfo {
* @param cls The class for which we look for the property. * @param cls The class for which we look for the property.
* @return The PropertyDescriptor or null if not found or in case of error * @return The PropertyDescriptor or null if not found or in case of error
*/ */
private PropertyDescriptor cachedBeanFieldLookup(String propertyName, Class cls) { private synchronized PropertyDescriptor cachedBeanFieldLookup(String propertyName, Class cls) {
boolean debug = ESLoader.isDebugJavaAccess(); boolean debug = ESLoader.isDebugJavaAccess();
// Check that there is a bean properties cache, chech if the property was cached // Check that there is a bean properties cache, chech if the property was cached
@ -258,7 +258,7 @@ public class ClassInfo {
* @param cls The class of the method being looked up * @param cls The class of the method being looked up
* @return The method array or null if none found or in case of error * @return The method array or null if none found or in case of error
*/ */
synchronized public static Method[] lookupPublicMethod(String functionName, Class cls) throws EcmaScriptException { public static Method[] lookupPublicMethod(String functionName, Class cls) throws EcmaScriptException {
ClassInfo classInfo = ClassInfo.ensureClassInfo(cls); ClassInfo classInfo = ClassInfo.ensureClassInfo(cls);
return classInfo.cachedPublicMethodLookup(functionName, cls); return classInfo.cachedPublicMethodLookup(functionName, cls);
} }
@ -336,7 +336,7 @@ public class ClassInfo {
* @param cls The class in which the function is defined * @param cls The class in which the function is defined
* @return The list of methods or null in case of error or if none found. * @return The list of methods or null in case of error or if none found.
*/ */
private Method [] cachedPublicMethodLookup(String functionName, Class cls) throws EcmaScriptException { private synchronized Method [] cachedPublicMethodLookup(String functionName, Class cls) throws EcmaScriptException {
boolean debug = ESLoader.isDebugJavaAccess(); boolean debug = ESLoader.isDebugJavaAccess();
if (publicMethods != null) { if (publicMethods != null) {
if (debug) System.out.println("** Method descriptor for class '" + if (debug) System.out.println("** Method descriptor for class '" +
@ -449,7 +449,7 @@ public class ClassInfo {
* @param cls The class of the method being looked up * @param cls The class of the method being looked up
* @return The method array or null if none found or in case of error * @return The method array or null if none found or in case of error
*/ */
synchronized public static Method[] lookupBeanMethod(String functionName, Class cls) { public static Method[] lookupBeanMethod(String functionName, Class cls) {
ClassInfo classInfo = ClassInfo.ensureClassInfo(cls); ClassInfo classInfo = ClassInfo.ensureClassInfo(cls);
return classInfo.cachedBeanMethodLookup(functionName, cls); return classInfo.cachedBeanMethodLookup(functionName, cls);
} }
@ -468,7 +468,7 @@ public class ClassInfo {
* @param cls The class in which the function is defined * @param cls The class in which the function is defined
* @return The list of methods or null in case of error or if none found. * @return The list of methods or null in case of error or if none found.
*/ */
private Method [] cachedBeanMethodLookup(String functionName, Class cls) { private synchronized Method [] cachedBeanMethodLookup(String functionName, Class cls) {
boolean debug = ESLoader.isDebugJavaAccess(); boolean debug = ESLoader.isDebugJavaAccess();
if (beanMethods != null) { if (beanMethods != null) {
if (debug) System.out.println("** Method descriptor for bean '" + if (debug) System.out.println("** Method descriptor for bean '" +