antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 5 Projects Releases 5 Activity Actions

Do not throw IOException on getLogger(...) anymore. Instead,

Browse source 
display an error message on standard out, try again and again
to open and write to the log file, and discard queued
log messages and display a warning message every now and then.
This commit is contained in:
hns 2002-04-26 12:47:04 +00:00
parent 3a0a234d50
commit 86eb2c075a
1 changed files with 29 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
src/helma/util/Logger.java
View file

@ -67,15 +67,25 @@ public final class Logger {
* Create a file logger. The actual file names do have numbers appended and are * Create a file logger. The actual file names do have numbers appended and are
* rotated every x bytes. * rotated every x bytes.
*/ */
private Logger (String dirname, String filename) throws IOException { private Logger (String dirname, String filename) {
this.filename = filename; this.filename = filename;
logdir = new File (dirname); logdir = new File (dirname);
logfile = new File (logdir, filename+".log"); logfile = new File (logdir, filename+".log");
try {
canonicalName = logfile.getCanonicalPath (); canonicalName = logfile.getCanonicalPath ();
} catch (IOException iox) {
canonicalName = logfile.getAbsolutePath ();
}
if (!logdir.exists()) if (!logdir.exists())
logdir.mkdirs (); logdir.mkdirs ();
try {
rotateLogFile (); rotateLogFile ();
} catch (IOException iox) {
System.err.println ("Error creating log "+canonicalName+": "+iox);
}
// create a synchronized list for log entries since different threads may // create a synchronized list for log entries since different threads may
// attempt to modify the list at the same time // attempt to modify the list at the same time
@ -89,13 +99,16 @@ public final class Logger {
/** /**
* Get a logger with a symbolic file name within a directory. * Get a logger with a symbolic file name within a directory.
*/ */
public static synchronized Logger getLogger (String dirname, String filename) throws IOException { public static synchronized Logger getLogger (String dirname, String filename) {
if (filename == null || dirname == null) if (filename == null || dirname == null)
throw new IOException ("Logger can't use null as file or directory name"); throw new RuntimeException ("Logger can't use null as file or directory name");
File file = new File (dirname, filename+".log"); File file = new File (dirname, filename+".log");
Logger log = null; Logger log = null;
if (loggerMap != null) if (loggerMap != null) try {
log = (Logger) loggerMap.get (file.getCanonicalPath()); log = (Logger) loggerMap.get (file.getCanonicalPath());
} catch (IOException iox) {
log = (Logger) loggerMap.get (file.getAbsolutePath());
}
if (log == null || log.isClosed ()) if (log == null || log.isClosed ())
log = new Logger (dirname, filename); log = new Logger (dirname, filename);
return log; return log;
@ -144,8 +157,9 @@ public final class Logger {
return; return;
try { try {
if (logfile != null && if (logfile != null &&
(logfile.length() > 10000000 || !logfile.exists())) { (logfile.length() > 10000000 || writer == null ||
// rotate log files each 10 megs !logfile.exists() || !logfile.canWrite())) {
// rotate log files each 10 megs of if we can't write to it
rotateLogFile (); rotateLogFile ();
} }
@ -168,13 +182,14 @@ public final class Logger {
} }
} catch (Exception x) { } catch (Exception x) {
System.err.println ("Error writing log file "+this+": "+x); int e = entries.size();
if (entries.size() > 1000) { if (e > 1000) {
// more than 1000 entries queued plus exception - something // more than 1000 entries queued plus exception - something
// is definitely wrong with this logger. Close and write error msg to std out. // is definitely wrong with this logger. Write a message to std err and
System.err.println (entries.size()+" log entries queued in "+this+". Closing Logger."); // discard queued log entries.
System.err.println ("Error writing log file "+this+": "+x);
System.err.println ("Discarding "+e+" log entries.");
entries.clear (); entries.clear ();
close ();
} }
} }
} }
@ -199,7 +214,7 @@ public final class Logger {
if (logfile.renameTo (archive)) if (logfile.renameTo (archive))
(new GZipper(archive)).start(); (new GZipper(archive)).start();
else else
System.err.println ("Error renaming old log file to "+archive); System.err.println ("Error rotating log file "+canonicalName+". Old file will possibly be overwritten!");
} }
writer = new PrintWriter (new FileWriter (logfile), false); writer = new PrintWriter (new FileWriter (logfile), false);
} }