antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 7 Projects Releases 5 Activity Actions

Performance improvement in HopObject.get() by trying child object first and property afterwards.

Browse source
This commit is contained in:
hns 2003-10-15 16:55:29 +00:00
parent 3271f940cd
commit 822307984b
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/helma/scripting/rhino/HopObject.java
View file

@ -296,6 +296,15 @@ public class HopObject extends ScriptableObject implements Wrapper {
if (id instanceof Number) { if (id instanceof Number) {
n = get(((Number) id).intValue(), this); n = get(((Number) id).intValue(), this);
} else if (id instanceof String) { } else if (id instanceof String) {
// HopObject.get() is more often called for child elements than for
// ordinary properties, so try a getChildElement() first. This seems
// to have quite an impact on get() performance.
n = node.getChildElement(id.toString());
if (n != null) {
return Context.toObject(n, core.global);
}
n = getFromNode(id.toString()); n = getFromNode(id.toString());
} else { } else {
throw new RuntimeException("Invalid type for id argument in HopObject.get(): "+id); throw new RuntimeException("Invalid type for id argument in HopObject.get(): "+id);
@ -765,13 +774,6 @@ public class HopObject extends ScriptableObject implements Wrapper {
} }
} }
} }
// as last resort, try to get property as anonymous subnode
// Object anon = node.getChildElement(name);
// if (anon != null) {
// return anon;
// }
} }
return NOT_FOUND; return NOT_FOUND;