antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 5 Projects Releases 5 Activity Actions

Added isStringColumn method that lets us check whether a column is

Browse source 
a string type and values therefore need to be quoted. Previously, also
number values were quoted in SQL queries since neither Oracle nor
MySQL seemed to care, but Sybase doesn't like quoted number vaules.
This commit is contained in:
hns 2002-03-06 13:05:40 +00:00
parent 00a396c2f5
commit 802d66ee80
1 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/helma/objectmodel/db/DbMapping.java
View file

@ -594,14 +594,32 @@ public class DbMapping implements Updatable {
public synchronized Schema getSchema () throws ClassNotFoundException, SQLException, DataSetException { public synchronized Schema getSchema () throws ClassNotFoundException, SQLException, DataSetException {
if (!isRelational ()) if (!isRelational ())
throw new SQLException ("Can't get Schema for non-relational data mapping"); throw new SQLException ("Can't get Schema for non-relational data mapping");
if (source == null && parentMapping != null) if (source == null && parentMapping != null)
return parentMapping.getSchema (); return parentMapping.getSchema ();
// Use local variable s to avoid synchronization (schema may be nulled elsewhere) // Use local variable s to avoid synchronization (schema may be nulled elsewhere)
Schema s = schema; Schema s = schema;
if (s != null) if (s != null)
return s; return s;
schema = new Schema ().schema (getConnection (), table, "*"); schema = new Schema ().schema (getConnection (), table, "*");
return schema; return schema;
}
/**
* Return true if the column identified by the parameter is a string type. This is
* used in query building to determine if a value needs to be quoted.
*/
public boolean isStringColumn (String columnName) throws SQLException {
try {
Schema s = getSchema ();
if (s == null)
throw new SQLException ("Error retrieving relational schema for "+this);
Column c = s.getColumn (columnName);
if (c == null)
throw new SQLException ("Column "+columnName+" not found in "+this);
return c.isString ();
} catch (Exception x) {
throw new SQLException (x.getMessage ());
}
} }
/** /**