antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 7 Projects Releases 5 Activity Actions

Fix bug in HopObject.remove() where we prematurely call unset().

Browse source 
The right thing *seems* to be to actually always call removeNode on the node's parent.
This commit is contained in:
hns 2003-09-02 16:08:05 +00:00
parent 262ba9d5e3
commit 75c7dff23b
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/helma/objectmodel/db/Node.java
View file

@ -720,7 +720,6 @@ public final class Node implements INode, Serializable {
if (pn != null) { if (pn != null) {
setParent((Node) pn); setParent((Node) pn);
// anonymous = !pinfo.named;
lastParentSet = System.currentTimeMillis(); lastParentSet = System.currentTimeMillis();
return pn; return pn;
@ -1189,11 +1188,7 @@ public final class Node implements INode, Serializable {
checkWriteLock(); checkWriteLock();
try { try {
if (!anonymous) {
getParent().unset(name);
} else {
getParent().removeNode(this); getParent().removeNode(this);
}
} catch (Exception x) { } catch (Exception x) {
return false; return false;
} }