antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 13 Projects Releases 5 Activity Actions

Do not use child collection timestamp as cache guard for object references.

Browse source 
Proper fix for bug 697 <http://dev.helma.org/bugs/show_bug.cgi?id=697>
This commit is contained in:
hns 2010-01-26 16:18:58 +00:00
parent ea87601291
commit 6bd0a80a02
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/helma/objectmodel/db/NodeManager.java
View file

@ -201,7 +201,7 @@ public final class NodeManager {
Key key;
DbMapping otherDbm = rel == null ? null : rel.otherType;
// check what kind of object we're looking for and make an apropriate key
// check what kind of object we're looking for and make an appropriate key
if (rel.isComplexReference()) {
// a key for a complex reference
key = new MultiKey(rel.otherType, rel.getKeyParts(home));
@ -278,7 +278,9 @@ public final class NodeManager {
} else {
// node fetched from db is null, cache result using nullNode
synchronized (cache) {
cache.put(key, new Node(home.getLastSubnodeChange()));
// do not use child collection timestamp as cache guard for object references
long lastchange = rel.isComplexReference() ? 0 : home.getLastSubnodeChange();
cache.put(key, new Node(lastchange));
// we ignore the case that onother thread has created the node in the meantime
return null;