Resolve FIXME but without fixing the issue
All checks were successful
Build / build (push) Successful in 19s

I tried to make this work but it might need a more thorough rewrite that I just cannot do.

The worst that can happen is stopping and starting Helma apps adding redundant ServletContextHandlers to the ContextHandlerCollection until Helma is restarted.
This commit is contained in:
Tobi Schäfer 2025-04-07 17:02:11 +02:00
parent 436862e87a
commit 6723df912e
Signed by: tobi
GPG key ID: 91FAE6FE2EBAC4C8

View file

@ -563,8 +563,8 @@ public class ApplicationManager implements XmlRpcHandler {
// unbind from Jetty HTTP server
if (ApplicationManager.this.jetty != null) {
if (this.appContext != null) {
// FIXME: Causing incompatible types: ServletContextHandler cannot be converted to Handler
// Is it necessary, anyway?
// Adding appContext to the ContextHandlerCollection works (see above) but removing it causes an exception of
// incompatible types: ServletContextHandler cannot be converted to Handler
//ApplicationManager.this.context.removeHandler(this.appContext);
this.appContext.stop();
this.appContext.destroy();