antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 7 Projects Releases 5 Activity Actions

* Optimize getDbColumns() for inheriting relational dbmappings.

Browse source 
* Avoid useless double assignment to column field
This commit is contained in:
hns 2007-02-15 14:13:53 +00:00
parent 3a263d9243
commit 514ad900c5
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/helma/objectmodel/db/DbMapping.java
View file

@ -926,8 +926,9 @@ public final class DbMapping {
public synchronized DbColumn[] getColumns() public synchronized DbColumn[] getColumns()
throws ClassNotFoundException, SQLException { throws ClassNotFoundException, SQLException {
if (!isRelational()) { if (!isRelational()) {
throw new SQLException("Can't get columns for non-relational data mapping " + throw new SQLException("Can't get columns for non-relational data mapping " + this);
this); } else if (inheritsStorage()) {
return parentMapping.getColumns();
} }
// Use local variable cols to avoid synchronization (schema may be nulled elsewhere) // Use local variable cols to avoid synchronization (schema may be nulled elsewhere)
@ -963,8 +964,7 @@ public final class DbMapping {
DbColumn col = new DbColumn(colName, meta.getColumnType(i + 1), rel, this); DbColumn col = new DbColumn(colName, meta.getColumnType(i + 1), rel, this);
list.add(col); list.add(col);
} }
columns = new DbColumn[list.size()]; columns = (DbColumn[]) list.toArray(new DbColumn[list.size()]);
columns = (DbColumn[]) list.toArray(columns);
} }
return columns; return columns;