antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 5 Projects Releases 5 Activity Actions

Check for readonly flag in putProperty method so that write protected

Browse source 
properties can't be modified from script code.

Deleted stuff that was permanently commented out:
  * setNode() method
  * readonly check for created and lastmodified props
This commit is contained in:
hns 2002-02-25 14:48:11 +00:00
parent 4e192c39c0
commit 4a3879b0ee
1 changed files with 9 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/helma/scripting/fesi/ESNode.java
View file

@ -89,21 +89,6 @@ public class ESNode extends ObjectPrototype {
return node; return node;
} }
/* public void setNode (INode node) {
if (node != null) {
this.node = node;
// set node handle to wrapped node
if (node instanceof helma.objectmodel.db.Node)
handle = ((helma.objectmodel.db.Node) node).getHandle ();
else
handle = null;
eval.objectcache.put (node, this);
// reset cache Node - will be reinitialized when needed
cache = null;
cacheWrapper = null;
}
} */
public void setPrototype (String protoName) { public void setPrototype (String protoName) {
checkNode (); checkNode ();
node.setPrototype (protoName); node.setPrototype (protoName);
@ -240,8 +225,7 @@ public class ESNode extends ObjectPrototype {
public void putProperty(String propertyName, ESValue propertyValue, int hash) throws EcmaScriptException { public void putProperty(String propertyName, ESValue propertyValue, int hash) throws EcmaScriptException {
checkNode (); checkNode ();
// eval.app.logEvent ("put property called: "+propertyName+", "+propertyValue.getClass()); // eval.app.logEvent ("put property called: "+propertyName+", "+propertyValue.getClass());
if (/* "lastmodified".equalsIgnoreCase (propertyName) || "created".equalsIgnoreCase (propertyName) || */ if ("cache".equalsIgnoreCase (propertyName))
"cache".equalsIgnoreCase (propertyName))
throw new EcmaScriptException ("Can't modify read-only property \""+propertyName+"\"."); throw new EcmaScriptException ("Can't modify read-only property \""+propertyName+"\".");
if ("subnodeRelation".equalsIgnoreCase (propertyName)) { if ("subnodeRelation".equalsIgnoreCase (propertyName)) {
@ -249,6 +233,14 @@ public class ESNode extends ObjectPrototype {
return; return;
} }
// check if the property is write protected, i.e. the type.property file describes it as [readonly]
DbMapping dbm = node.getDbMapping ();
if (dbm != null) {
Relation rel = dbm.getPropertyRelation (propertyName);
if (rel != null && rel.isReadonly ())
return;
}
if (propertyValue instanceof ESNull || propertyValue instanceof ESUndefined) if (propertyValue instanceof ESNull || propertyValue instanceof ESUndefined)
node.unset (propertyName); node.unset (propertyName);
else if (propertyValue instanceof ESString) else if (propertyValue instanceof ESString)