antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 7 Projects Releases 5 Activity Actions

Fixed cache corruption when primary key is purged from cache but node is still cached with secondary key

Browse source
This commit is contained in:
hns 2000-12-31 15:42:42 +00:00
parent 3598f6bd3f
commit 42cc2d9ffb
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/helma/objectmodel/db/NodeManager.java
View file

@ -195,6 +195,10 @@ public final class NodeManager {
if (node != null && node.getState() != Node.INVALID) { if (node != null && node.getState() != Node.INVALID) {
// tx.timer.endEvent ("getNode "+kstr); // tx.timer.endEvent ("getNode "+kstr);
// if we didn't fetch the node via its primary key, refresh the primary key in the cache.
// otherwise we risk cache corroption (duplicate node creation) if the node is fetched by its primary key
if (!rel.usesPrimaryKey ())
cache.put (node.getKey (), node);
return node; return node;
} }
@ -224,8 +228,12 @@ public final class NodeManager {
} // synchronized } // synchronized
} }
if (node != null) if (node != null) {
// update primary key in cache, see above
if (!rel.usesPrimaryKey ())
cache.put (node.getKey (), node);
tx.visitCleanNode (node.getKey (), node); tx.visitCleanNode (node.getKey (), node);
}
// tx.timer.endEvent ("getNode "+kstr); // tx.timer.endEvent ("getNode "+kstr);
return node; return node;