antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 7 Projects Releases 5 Activity Actions

Synchronize more methods in TypeManager to prevent race conditions.

Browse source
This commit is contained in:
hns 2008-07-17 12:08:10 +00:00
parent d1600d4783
commit 41a422fd01
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/helma/framework/core/TypeManager.java
View file

@ -101,7 +101,7 @@ public final class TypeManager {
* Run through application's prototype directories and create prototypes, but don't * Run through application's prototype directories and create prototypes, but don't
* compile or evaluate any scripts. * compile or evaluate any scripts.
*/ */
public void createPrototypes() throws IOException { public synchronized void createPrototypes() throws IOException {
// create standard prototypes. // create standard prototypes.
for (int i = 0; i < standardTypes.length; i++) { for (int i = 0; i < standardTypes.length; i++) {
createPrototype(standardTypes[i], null); createPrototype(standardTypes[i], null);
@ -126,7 +126,7 @@ public final class TypeManager {
lastCheck = System.currentTimeMillis(); lastCheck = System.currentTimeMillis();
} }
protected void checkRepository(Repository repository, boolean update) throws IOException { protected synchronized void checkRepository(Repository repository, boolean update) throws IOException {
Repository[] list = repository.getRepositories(); Repository[] list = repository.getRepositories();
for (int i = 0; i < list.length; i++) { for (int i = 0; i < list.length; i++) {
@ -183,7 +183,7 @@ public final class TypeManager {
* Run through application's prototype sources and check if * Run through application's prototype sources and check if
* there are any prototypes to be created. * there are any prototypes to be created.
*/ */
private void checkRepositories() throws IOException { private synchronized void checkRepositories() throws IOException {
List list = app.getRepositories(); List list = app.getRepositories();
// walk through repositories and check if any of them have changed. // walk through repositories and check if any of them have changed.
@ -284,7 +284,7 @@ public final class TypeManager {
* @param repository the first prototype source * @param repository the first prototype source
* @return the newly created prototype * @return the newly created prototype
*/ */
public Prototype createPrototype(String typename, Repository repository) { public synchronized Prototype createPrototype(String typename, Repository repository) {
Prototype proto = new Prototype(typename, repository, app); Prototype proto = new Prototype(typename, repository, app);
// put the prototype into our map // put the prototype into our map