antville/helma
antville/helma
1
1
Fork 0
Code Issues 5 Pull requests 7 Projects Releases 5 Activity Actions 1

Improved documentation for checkConstraints(), adding info about its shortcomings.

Browse source 
Slightly improved method body by only calling getNonVirtualParent() once.
This commit is contained in:
hns 2004-02-27 14:44:34 +00:00
parent 5c8d774f47
commit 38c9d74be6
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/helma/objectmodel/db/Relation.java
View file

@ -963,6 +963,13 @@ public final class Relation {
/** /**
* Check if the child node fullfills the constraints defined by this relation. * Check if the child node fullfills the constraints defined by this relation.
* FIXME: This always returns false if the relation has a filter value set,
* since we can't determine if the filter constraints are met without
* querying the database.
*
* @param parent the parent object - may be a virtual or group node
* @param child the child object
* @return true if all constraints are met
*/ */
public boolean checkConstraints(Node parent, Node child) { public boolean checkConstraints(Node parent, Node child) {
// problem: if a filter property is defined for this relation, // problem: if a filter property is defined for this relation,
@ -971,16 +978,18 @@ public final class Relation {
// is defined, we return false as soon as the modified-time is greater // is defined, we return false as soon as the modified-time is greater
// than the create-time of the child, i.e. if the child node has been // than the create-time of the child, i.e. if the child node has been
// modified since it was first fetched from the db. // modified since it was first fetched from the db.
if ((filter != null) && (child.lastModified() > child.created())) { if (filter != null && child.lastModified() > child.created()) {
return false; return false;
} }
INode nonvirtual = parent.getNonVirtualParent();
for (int i = 0; i < constraints.length; i++) { for (int i = 0; i < constraints.length; i++) {
String propname = constraints[i].foreignProperty(); String propname = constraints[i].foreignProperty();
if (propname != null) { if (propname != null) {
INode home = constraints[i].isGroupby ? parent INode home = constraints[i].isGroupby ? parent
: parent.getNonVirtualParent(); : nonvirtual;
String value = null; String value = null;
if (constraints[i].localKeyIsPrimary(home.getDbMapping())) { if (constraints[i].localKeyIsPrimary(home.getDbMapping())) {