Before saving modified Site.page skin, check if it contains the <% response.body %> macro #67

New issue

Closed

opened 2015-04-04 16:12:35 +00:00 by GoogleCodeExporter · 3 comments

GoogleCodeExporter commented

2015-04-04 16:12:35 +00:00

(Migrated from github.com)

... to prevent a not so infrequent error that makes the layout of a site
impossible to repair for novices. 

The error message could inform the user that he might have tried to save an
incompatible layout (e.g. a file for blogspot or WordPress) and suggest
having a look at layouts.antville.org, noting that these layouts were suited. 

(Had something like that been added to the code a few weeks ago?)

Original issue reported on code.google.com by kinomu.w...@gmail.com on 12 Jan 2010 at 3:05

``` ... to prevent a not so infrequent error that makes the layout of a site impossible to repair for novices. The error message could inform the user that he might have tried to save an incompatible layout (e.g. a file for blogspot or WordPress) and suggest having a look at layouts.antville.org, noting that these layouts were suited. (Had something like that been added to the code a few weeks ago?) ``` Original issue reported on code.google.com by `kinomu.w...@gmail.com` on 12 Jan 2010 at 3:05

GoogleCodeExporter commented

2015-04-04 16:12:36 +00:00

(Migrated from github.com)

More precisely: in case the macro is missing, I wouldn't add it automatically 
and
save the skin but instead display an error message: "The modified skin couldn't 
be
saved because it doesn't contain the <% response.body %>-macro. You might have
deleted it erroneously or tried to save an incompatible template (e.g. from 
WordPress
or blogger.*com*). You find information on changing the layout of your site in 
the
[link FAQ] and dozens of compatible layouts at [http://layouts.antville.org/
layouts.antville.org]."

Original comment by kinomu.w...@gmail.com on 12 Jan 2010 at 4:56

``` More precisely: in case the macro is missing, I wouldn't add it automatically and save the skin but instead display an error message: "The modified skin couldn't be saved because it doesn't contain the <% response.body %>-macro. You might have deleted it erroneously or tried to save an incompatible template (e.g. from WordPress or blogger.*com*). You find information on changing the layout of your site in the [link FAQ] and dozens of compatible layouts at [http://layouts.antville.org/ layouts.antville.org]." ``` Original comment by `kinomu.w...@gmail.com` on 12 Jan 2010 at 4:56

GoogleCodeExporter commented

2015-04-04 16:12:36 +00:00

(Migrated from github.com)

I already added exactly this feature (not exactly the wording, though) to the 
source code 
in r3892.

Original comment by interf...@p3k.org on 15 Jan 2010 at 9:47

Changed state: Fixed

``` I already added exactly this feature (not exactly the wording, though) to the source code in r3892. ``` Original comment by `interf...@p3k.org` on 15 Jan 2010 at 9:47 - Changed state: **Fixed**

GoogleCodeExporter commented

2015-04-04 16:12:36 +00:00

(Migrated from github.com)

Original comment by kinomu.w...@gmail.com on 2 Feb 2010 at 6:01