Refactor custom content feature for stories #144

New issue

Open

opened 2015-04-04 16:14:13 +00:00 by GoogleCodeExporter · 3 comments

GoogleCodeExporter commented

2015-04-04 16:14:13 +00:00

(Migrated from github.com)

The current implementation of custom content does not make any difference 
between content and properties, ie. custom content is anything that is not a 
predefined property (or “save” [1]).

This is causing unwanted metadata to be stored in the database when posting 
data from a third-party client which adds its own parameters to the request. 
E.g. a jQuery JSONP request adds entries for “callback” and “_”.

Custom content probably should be prefixed, although that means the database 
entries need to be updated with the prefix, too.

Moreover, the current implementation is distributed between the main code and 
the compatibility layer (content update in main, macros in compat).

Either custom content is only supported in the compatibility layer or it should 
become a fully integrated feature again, or at least an extra.

All in all refactoring would be a good idea.

[1] 
http://code.google.com/p/antville/source/browse/trunk/code/Story/Story.js?r=4402
#367

Original issue reported on code.google.com by interf...@p3k.org on 15 May 2011 at 2:38

``` The current implementation of custom content does not make any difference between content and properties, ie. custom content is anything that is not a predefined property (or “save” [1]). This is causing unwanted metadata to be stored in the database when posting data from a third-party client which adds its own parameters to the request. E.g. a jQuery JSONP request adds entries for “callback” and “_”. Custom content probably should be prefixed, although that means the database entries need to be updated with the prefix, too. Moreover, the current implementation is distributed between the main code and the compatibility layer (content update in main, macros in compat). Either custom content is only supported in the compatibility layer or it should become a fully integrated feature again, or at least an extra. All in all refactoring would be a good idea. [1] http://code.google.com/p/antville/source/browse/trunk/code/Story/Story.js?r=4402 #367 ``` Original issue reported on code.google.com by `interf...@p3k.org` on 15 May 2011 at 2:38

GoogleCodeExporter commented

2015-04-04 16:14:13 +00:00

(Migrated from github.com)

Original comment by m...@tobischaefer.com on 28 Jul 2013 at 8:50

Added labels: Milestone-Release-1.5
Removed labels: Milestone-Release-1.4

Original comment by `m...@tobischaefer.com` on 28 Jul 2013 at 8:50 - Added labels: **Milestone-Release-1.5** - Removed labels: **Milestone-Release-1.4**

GoogleCodeExporter commented

2015-04-04 16:14:13 +00:00

(Migrated from github.com)

Original comment by m...@tobischaefer.com on 7 Mar 2015 at 5:59

Original comment by `m...@tobischaefer.com` on 7 Mar 2015 at 5:59

github-actions[bot] commented

2021-05-17 02:38:23 +00:00

(Migrated from github.com)

Stale issue message