From d19b83008be342bcc5a6e9d78d4efa194410055f Mon Sep 17 00:00:00 2001
From: hns <hannesw@gmail.com>
Date: Thu, 8 Feb 2007 12:53:07 +0000
Subject: [PATCH] * Implement equals() and hashCode() in order not to create
 new   database connections for each DbSource instance when a connection   to
 the database is already registered.

---
 src/helma/objectmodel/db/DbSource.java | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/helma/objectmodel/db/DbSource.java b/src/helma/objectmodel/db/DbSource.java
index 7ad09904..0840d3de 100644
--- a/src/helma/objectmodel/db/DbSource.java
+++ b/src/helma/objectmodel/db/DbSource.java
@@ -38,6 +38,8 @@ public class DbSource {
     private boolean isOracle, isMySQL, isPostgreSQL;
     private long lastRead = 0L;
     private Hashtable dbmappings = new Hashtable();
+    // compute hashcode statically because it's expensive and we need it often
+    private int hashcode;
 
     /**
      * Creates a new DbSource object.
@@ -101,6 +103,8 @@ public class DbSource {
         lastRead = (defaultProps == null) ? props.lastModified()
                                           : Math.max(props.lastModified(),
                                                      defaultProps.lastModified());
+        // use properties hashcode for ourselves
+        hashcode = props.hashCode();
         // get JDBC URL and driver class name
         url = props.getProperty(name + ".url");
         driver = props.getProperty(name + ".driver");
@@ -224,4 +228,18 @@ public class DbSource {
     protected DbMapping getDbMapping(String tablename) {
         return (DbMapping) dbmappings.get(tablename.toUpperCase());
     }
+
+    /**
+     * Returns a hash code value for the object.
+     */
+    public int hashCode() {
+        return hashcode;
+    }
+
+    /**
+     * Indicates whether some other object is "equal to" this one.
+     */
+    public boolean equals(Object obj) {
+        return obj instanceof DbSource && props.equals(((DbSource) obj).props);
+    }
 }