From b3112585bb3d533a7f144165d9078494956140a8 Mon Sep 17 00:00:00 2001 From: hns Date: Wed, 1 Apr 2009 16:03:30 +0000 Subject: [PATCH] Simplify code a little bit. --- src/helma/objectmodel/db/Relation.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/helma/objectmodel/db/Relation.java b/src/helma/objectmodel/db/Relation.java index c657a7ed..d841e530 100644 --- a/src/helma/objectmodel/db/Relation.java +++ b/src/helma/objectmodel/db/Relation.java @@ -921,11 +921,10 @@ public final class Relation { if (maxSize > 0) { if (otherType.isOracle()) { // see http://www.oracle.com/technology/oramag/oracle/06-sep/o56asktom.html - int minRow = offset; - int maxRow = minRow + maxSize; - if (minRow > 0) { + int maxRow = offset + maxSize; + if (offset > 0) { q.insert(0, "SELECT * FROM ( SELECT /*+ FIRST_ROWS(n) */ a.*, ROWNUM rnum FROM ("); - q.append(") a WHERE ROWNUM <= ").append(maxRow).append(") WHERE rnum > ").append(minRow); + q.append(") a WHERE ROWNUM <= ").append(maxRow).append(") WHERE rnum > ").append(offset); } else { q.insert(0, "SELECT /*+ FIRST_ROWS(n) */ * FROM ("); q.append(") WHERE ROWNUM <= ").append(maxRow);