From 34b1a8641af7748c70c837e9d27648659bdffabc Mon Sep 17 00:00:00 2001 From: hns Date: Thu, 9 Feb 2006 14:11:08 +0000 Subject: [PATCH] * Fix a potential memory leak: Don't allow entries list to grow indefinitely. If the list reaches a certain size (2000 entries), further entries are discarded. --- src/helma/util/Logger.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/helma/util/Logger.java b/src/helma/util/Logger.java index 28224029..07f3b39b 100644 --- a/src/helma/util/Logger.java +++ b/src/helma/util/Logger.java @@ -129,8 +129,11 @@ public class Logger implements Log { if ((System.currentTimeMillis() - 1000) > dateLastRendered) { renderDate(); } - - entries.add(dateCache + msg); + // add a safety net so we don't grow indefinitely even if writer thread + // has gone. the 2000 entries threshold is somewhat arbitrary. + if (entries.size() < 2000) { + entries.add(dateCache + msg); + } } /**