From 17e8ea6d82362c1980e14c1aa0268fdb8ddc16d4 Mon Sep 17 00:00:00 2001 From: hns Date: Wed, 26 Mar 2008 18:53:31 +0000 Subject: [PATCH] * Close sql statement after the logging. Fixes bug 605. --- helma/Database.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/helma/Database.js b/helma/Database.js index ab49accd..14a6400d 100644 --- a/helma/Database.js +++ b/helma/Database.js @@ -168,17 +168,17 @@ helma.Database = function(source) { } result[result.length] = row; } + var logTimeStop = isLogSqlEnabled ? java.lang.System.currentTimeMillis() : 0; + if (isLogSqlEnabled) { + var tableName = metaData.getColumnCount() > 0 ? metaData.getTableName(1) : null; + app.getLogger("helma." + app.name + ".sql").info("SQL DIRECT_QUERY " + (tableName || "-") + " " + (logTimeStop - logTimeStart) + ": " + sql); + } try { statement.close(); resultSet.close(); } catch (error) { // ignore } - var logTimeStop = isLogSqlEnabled ? java.lang.System.currentTimeMillis() : 0; - if (isLogSqlEnabled) { - var tableName = metaData.getColumnCount() > 0 ? metaData.getTableName(1) : null; - app.getLogger("helma." + app.name + ".sql").info("SQL DIRECT_QUERY " + (tableName || "-") + " " + (logTimeStop - logTimeStart) + ": " + sql); - } return result; };